Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Document not DocType #185

Merged
merged 3 commits into from
Jun 15, 2019
Merged

Conversation

ogiogi93
Copy link

@ogiogi93 ogiogi93 commented Jun 15, 2019

I think from django_elasticsearch_dsl import Document is not a correct path 🤔

just import Document not DocType

@ogiogi93 ogiogi93 changed the title Update README.md to fix wrong importing path Import Document not DocType Jun 15, 2019
@safwanrahman
Copy link
Collaborator

LGTM. r+

@safwanrahman safwanrahman merged commit 5c327ac into django-es:master Jun 15, 2019
@Acetonen
Copy link
Contributor

@safwanrahman you already broke my production with this)))
image

i install django_elasticsearch_dsl directly from git( because pip version don't update

@safwanrahman
Copy link
Collaborator

@Acetonen Sorry. How it broke your production?

@Acetonen
Copy link
Contributor

@safwanrahman like this:

image

I've fixed it, but I think you have to leave here:

image

this:
from .documents import Document, DocType
until you get stable and updated PIP version

@safwanrahman
Copy link
Collaborator

@Acetonen You must install a specific version as mentioned in the doc not the master branch.
pip install https://github.com/sabricot/django-elasticsearch-dsl/archive/6.4.1.tar.gz

@Acetonen
Copy link
Contributor

@safwanrahman yea, my fault(

@ogiogi93 ogiogi93 deleted the fix/readme branch June 16, 2019 07:08
jayvdb added a commit to jayvdb/bluebottle that referenced this pull request Oct 4, 2020
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
jayvdb added a commit to jayvdb/bluebottle that referenced this pull request Dec 9, 2020
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
jayvdb added a commit to jayvdb/bluebottle that referenced this pull request Dec 10, 2020
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
jayvdb added a commit to jayvdb/bluebottle that referenced this pull request Jan 1, 2021
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
jayvdb added a commit to jayvdb/bluebottle that referenced this pull request Jan 1, 2021
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
jayvdb added a commit to jayvdb/bluebottle that referenced this pull request Jan 1, 2021
DocType was replaced with Document as top level import.
django-es/django-elasticsearch-dsl#185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants