Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add faces for which-key #58

Merged
merged 1 commit into from
Jun 28, 2016
Merged

add faces for which-key #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions monokai-theme.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5652,6 +5652,34 @@ Also affects 'linum-mode' background."
((,class (:foreground ,monokai-green))
(,terminal-class (:foreground ,terminal-monokai-green))))

;; which-key
`(which-key-key-face
((,class (:foreground ,monokai-green
:weight bold))
(,terminal-class (:foreground ,terminal-monokai-green
:weight bold))))

`(which-key-separator-face
((,class (:foreground ,monokai-comments))
(,terminal-class (:foreground ,terminal-monokai-comments))))

`(which-key-note-face
((,class (:foreground ,monokai-comments))
(,terminal-class (:foreground ,terminal-monokai-comments))))

`(which-key-command-description-face
((,class (:foreground ,monokai-fg))
(,terminal-class (:foreground ,terminal-monokai-fg))))

`(which-key-local-map-description-face
((,class (:foreground ,monokai-yellow-hc))
(,terminal-class (:foreground ,terminal-monokai-yellow-hc))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is monokai-yellow too bright?

Copy link
Contributor Author

@deb0ch deb0ch Jun 28, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that with monokai-yellow it might make the distinction between command groups and commands less instinctive, and I find it smoother to the eye.

But then again, it is personnal taste and even if I find it still distinguishable it might not be the case for everyone or everyone's screen, so I might be wrong.

Here is a screenshot with monokai-yellow so that you can see for yourself:

screenshot from 2016-06-28 11-12-47

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, agreed. Thanks for the screenshot.


`(which-key-group-description-face
((,class (:foreground ,monokai-red
:weight bold))
(,terminal-class (:foreground ,terminal-monokai-red
:weight bold))))
;; window-number-mode
`(window-number-face
((,class (:foreground ,monokai-green))
Expand Down