add faces for which-key #58
Conversation
| (,terminal-class (:foreground ,terminal-monokai-red | ||
| :weight bold)))) | ||
|
|
||
| ;; `(which-key-special-key-face |
There was a problem hiding this comment.
https://github.com/justbur/emacs-which-key/blob/master/which-key.el#L405
It looks like it inherits the key-face but inverts it. The face is applied under these conditions: ""These keys will automatically be truncated to one character
and have `which-key-special-key-face' applied to them. This is
disabled by default. Try this to see the effect."
There was a problem hiding this comment.
Ok, so what should we do about it ?
Remove it from the theme or explicitly set the invert-video + weight bold just like in the package ?
There was a problem hiding this comment.
It seems to be the same strategy with which-key-highlighted-command-face.
I think delete the commented blocks. We (I) can add them if they're required in the future.
|
This is a great PR. Thank you :) |
deb0ch
force-pushed
the
PR/which-key-support
branch
from
543b539
to
e05a2ad
Compare
|
Removed commented blocks. Thanks to you too, glad you like it ! 😄 |
Add support for which-key faces.
Before:
Now:
Note that local-map specific commands are slightly yellow, making them distinguishable but not as bright as command groups so that it remains instinctive that it is a command and not a command group.
NB: Some of the faces I wasn't exactly sure what they did so I left them commented as information to the reader.