Optimizing ListConfig.__contains__ #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
odelalleau
reviewed
Feb 9, 2021
| ], | ||
| ) | ||
| def test_list_iter(lst: List[Any], benchmark: Any) -> None: | ||
| # Performance is really bad for list config iteration, not sure why. |
There was a problem hiding this comment.
Why is that surprising? If you compare to a regular list, ListConfig is doing a lot more stuff to check if any interpolation needs to be resolved, while a regular list can instantly return the reference to the object.
There was a problem hiding this comment.
Because it's 500 times slower :).
I don't think it's justified. I tried to profile it a bit and do some blind optimizations but was not able to pinpoint the cause.
There was a problem hiding this comment.
Ok -- actually given the speed-up that you got here, I do agree that it should be possible to iterate faster (x in lst shouldn't be much faster than for y in lst -- at least when iterating through the whole list in both cases)
Speedup from 1200x slower than standard list contains to only 68 times slower :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup from 1200x slower than standard list contains to only 68 times slower (~15x).
Closes #529