Optimized ListConfig.__contains__()

Speedup from 1200x slower than standard list contains to only 68 times slower :)

news/529.feature

@@ -0,0 +1 @@
+ListConfig.__contains__ optimized, about 15x faster in a benchmark

omegaconf/listconfig.py

@@ -539,7 +539,18 @@ def __iadd__(self, other: Iterable[Any]) -> "ListConfig":
         return self
 
     def __contains__(self, item: Any) -> bool:
-        for x in iter(self):
+        if self._is_none():
+            raise TypeError(
+                "Cannot check if an item is in a ListConfig object representing None"
+            )
+        if self._is_missing():
+            raise MissingMandatoryValue(
+                "Cannot check if an item is in missing ListConfig"
+            )
+
+        lst = self.__dict__["_content"]
+        for x in lst:
+            x = x._dereference_node()
             if x == item:
                 return True
         return False

tests/test_basic_ops_list.py

@@ -119,6 +119,32 @@ def test_in_with_interpolation() -> None:
     assert 10 in c.a
 
 
+@pytest.mark.parametrize(
+    ("lst", "expected"),
+    [
+        pytest.param(
+            ListConfig(content=None),
+            pytest.raises(
+                TypeError,
+                match="Cannot check if an item is in a ListConfig object representing None",
+            ),
+            id="ListConfig(None)",
+        ),
+        pytest.param(
+            ListConfig(content="???"),
+            pytest.raises(
+                MissingMandatoryValue,
+                match="Cannot check if an item is in missing ListConfig",
+            ),
+            id="ListConfig(???)",
+        ),
+    ],
+)
+def test_not_in_special_lists(lst: Any, expected: Any) -> None:
+    with expected:
+        "foo" not in lst
+
+
 def test_list_config_with_list() -> None:
     c = OmegaConf.create([])
     assert isinstance(c, ListConfig)