api change: dictconfig.get("missing") returns None

news/527.api_change

@@ -0,0 +1 @@
+DictConfig get access, e.g. `cfg.get("foo")`, now returns `None` if the key "foo" does not exist

omegaconf/dictconfig.py

@@ -404,12 +404,12 @@ def __delitem__(self, key: DictKeyType) -> None:
 
         del self.__dict__["_content"][key]
 
-    def get(self, key: DictKeyType, default_value: Any = DEFAULT_VALUE_MARKER) -> Any:
+    def get(self, key: DictKeyType, default_value: Any = None) -> Any:
+        """Return the value for `key` if `key` is in the dictionary, else
+        `default_value` (defaulting to `None`)."""
         try:
             return self._get_impl(key=key, default_value=default_value)
-        except ConfigAttributeError:
-            return None
-        except Exception as e:
+        except KeyValidationError as e:
             self._format_and_raise(key=key, value=None, cause=e)
 
     def _get_impl(self, key: DictKeyType, default_value: Any) -> Any:

tests/test_omegaconf.py

@@ -95,7 +95,7 @@ def test_is_missing(
 ) -> None:
     cfg = OmegaConf.create(cfg)
     with expectation:
-        cfg.get(key)
+        cfg[key]
 
     assert OmegaConf.is_missing(cfg, key) == expected_is_missing
     OmegaConf.set_struct(cfg, True)