Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api change: dictconfig.get("missing") returns None #528

Merged
merged 1 commit into from
Feb 9, 2021
Merged

api change: dictconfig.get("missing") returns None #528

merged 1 commit into from
Feb 9, 2021

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Feb 9, 2021

Closes #527

@Jasha10 Jasha10 mentioned this pull request Feb 9, 2021
Merged
omry
omry approved these changes Feb 9, 2021
View reviewed changes
Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@omry omry merged commit f2c7705 into omry:master Feb 9, 2021
@Jasha10 Jasha10 deleted the update_DictConfig_get branch February 9, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omry omry omry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DictConfig.get('missing') inconsistent with python dict.get('missing')
2 participants
@Jasha10 @omry