Merge element type #499
Merged
Merge element type #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omry
force-pushed
the
merge_element_type
branch
from
883035b to
6b67d96
Compare
Jasha10
reviewed
Jan 27, 2021
tests/test_merge.py
Outdated
Comment on lines
189
to
212
| pytest.param( | ||
| ( | ||
| DictConfig({"user007": "???"}, element_type=User), | ||
| {"user007": {"age": 99}}, | ||
| ), | ||
| {"user007": {"name": "???", "age": 99}}, | ||
| id="dict:merge_into_sc_element_type:into_missing_element", | ||
| ), | ||
| pytest.param( | ||
| ( | ||
| DictConfig({"user007": User("bond", 7)}, element_type=User), | ||
| {"user007": {"age": 99}}, | ||
| ), | ||
| {"user007": {"name": "bond", "age": 99}}, | ||
| id="dict:merge_into_sc_element_type:merging_with_existing_element", | ||
| ), | ||
| pytest.param( | ||
| ( | ||
| DictConfig({"user007": "???"}, element_type=User), | ||
| {"user007": {"age": 99}}, | ||
| ), | ||
| {"user007": {"name": "???", "age": 99}}, | ||
| id="dict:merge_into_sc_element_type:merging_into_missing", | ||
| ), |
There was a problem hiding this comment.
I think that the tests with id="dict:merge_into_sc_element_type:into_missing_element" and id="dict:merge_into_sc_element_type:merging_into_missing" are duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496