Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge: Don't overwrite element_type=strucutured #497

Closed
wants to merge 2 commits into from
Closed

Merge: Don't overwrite element_type=strucutured #497

wants to merge 2 commits into from

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Jan 25, 2021

Closes #496.

@Jasha10 Jasha10 marked this pull request as draft January 26, 2021 01:54
@omry
Copy link
Owner

omry commented Jan 27, 2021

I have an update to this diff.
I don't know how (or if it's possible) to add a commit to your PR so I am going to create a new one.

@omry
Copy link
Owner

omry commented Jan 27, 2021

see #499

@Jasha10
Copy link
Collaborator Author

Jasha10 commented Jan 27, 2021

Ok, closing this PR in favor of #499.

@Jasha10 Jasha10 closed this Jan 27, 2021
@Jasha10 Jasha10 deleted the merge-dont-overwrite-structured-value branch January 27, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DictConfig merge throws away data when element_type is structured
2 participants
@Jasha10 @omry