Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strucd mode invalid access -> AttributeError #109

Merged
merged 1 commit into from
Dec 29, 2019
Merged

strucd mode invalid access -> AttributeError #109

merged 1 commit into from
Dec 29, 2019

Conversation

omry
Copy link
Owner

@omry omry commented Dec 29, 2019

In struct mode, accessing a missing key now raises AttributeError and not key error

@coveralls
Copy link

coveralls commented Dec 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 599

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 585: 0.0%
Covered Lines: 1292
Relevant Lines: 1292
💛 - Coveralls

@omry omry merged commit ba8a57f into master Dec 29, 2019
@omry omry deleted the attribute_error branch December 29, 2019 03:04
@omry omry mentioned this pull request Dec 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omry @coveralls