Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw AttributeError in struct mode #94

Closed
omry opened this issue Dec 7, 2019 · 1 comment
Closed

throw AttributeError in struct mode #94

omry opened this issue Dec 7, 2019 · 1 comment
Assignees
@omry
Milestone
OmegaConf 2.0.0

Comments

@omry
Copy link
Owner

omry commented Dec 7, 2019

In struct mode, accessing an invalid attribute through getattr() should result in an AttributeError and not in a KeyError.
@omry omry added this to the OmegaConf 1.5.0 milestone Dec 7, 2019
@omry omry self-assigned this Dec 7, 2019
@omry
Copy link
Owner Author

omry commented Dec 29, 2019

fixed by #109

@omry omry closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omry omry

Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.0.0
Development

No branches or pull requests
1 participant
@omry