👼 Automate schema creation #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psbrandt
commented
Jan 2, 2020
src/main/resources/flyway/migrations/postgresql/V1.0.3__Create_Observation_view.pg.sql
Outdated
Show resolved
Hide resolved
psbrandt
commented
Jan 3, 2020
| measurement.person_id, | ||
| measurement.measurement_concept_id AS observation_concept_id, | ||
| measurement.measurement_date AS observation_date, | ||
| $sql$ || measurement_col_string || $sql$ AS observation_time, |
There was a problem hiding this comment.
These multi-version support hacks should be removed. I think the better approach is to have branches/releases that support specific, well-documented versions.
There was a problem hiding this comment.
different branches for different OMOP version are created. The master branch is 5.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tools and associated tests to automatically generate the tables required by OMOP on FHIR. I chose to use Flyway to manage migrations, as this what is used in the WebAPI.
Right now, migrations must be performed manually using Maven (see README), but it will be easy to have them automatically applied by Flyway when starting the main WAR file. Further, using a migration tool like Flyway will allow us to disable
hibernate.hbm2ddl.auto(the issue I raised in omoponfhir-stu3-server#1), and thus give implementers more control over their schema. For example, they could give OMOP on FHIR write access to only the few tables it needs to update.