Schema Mutation

[psbrandt]

I have a question regarding the following Hibernate configuration option:

omoponfhir-stu3-server/src/main/java/edu/gatech/chai/omoponfhir/config/FhirServerConfig.java

Line 79 in c2ad29b

extraProperties.put("hibernate.hbm2ddl.auto", "update");

Does this mean that using OMOP on FHIR could mutate the CDM schema? If so, is the intention to use this in production, or only in development? What preparation should a potential implementer do to prevent potentially undesirable mutations to their production CDM schema?

[myungchoi]

Our intention is to first use in development environment. There are other configurations that can be set to limit the access.

For the hibernate auto update, we set it to update as default because there were some needs for the server to update database schema. We can make this configurable if it can better support community's needs.

[psbrandt]

The main problem is that this setting may causes unexpected changes, and do so without notifying the user. I don't think people would like this situation in the production environment 🙂

To me it makes more sense to require manual (or automated with tools like Flyway or Liquibase) preparation of the schema. Hence my PR on the other repo.