Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated html flag removed in newer version of Java #21

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

jburel
Copy link
Member

@jburel jburel commented Dec 16, 2022

Doc generation is failing in Java 11 in newer version of CI
javadoc: error - invalid flag: -html5
This removes the deprecated html5 options in JDK 11

@jburel jburel requested a review from sbesson December 17, 2022 08:08
@jburel
Copy link
Member Author

jburel commented Dec 17, 2022

unfortunately the build system does not update the line
This implies that the build on jenkins will fail with the same error
This is a blocker for the Jenkins upgrade

@jburel jburel changed the title remove html flag remove in newer version of Java remove deprecated html flag remove in newer version of Java Dec 17, 2022
@jburel
Copy link
Member Author

jburel commented Dec 18, 2022

@sbesson
Copy link
Member

sbesson commented Dec 19, 2022

Looks good and matches the fact that the -html5 flag is dropped in Java11.
Two questions:

  • do we know how this modifies the generated Javadoc?
  • it's surprising this was not detected in any of the omero-* components. Is it because the task is not invoked or because we are not running these builds in JDK11?

@jburel
Copy link
Member Author

jburel commented Dec 19, 2022

The GHA runs on 1.8 and 11 but we only run build not publishToMavenLocal (something to adjust)
That been said, I could not reproduce the problem via GHA and running publishToMavenLocal instead of build. So it could be that depending on the JAva 11 installed the problem is there or not

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8182765, my impression is that the JDK evolution has moved towards generating HTML5 by default.

I agree with the quick introduction and dropping of these flags, they are causing more trouble than necessary. No objection to getting this merged and released and effectively let the JDK decide the default set of parameters.

@sbesson sbesson mentioned this pull request Dec 19, 2022
@jburel jburel merged commit 90f222a into ome:master Dec 21, 2022
@jburel jburel changed the title remove deprecated html flag remove in newer version of Java remove deprecated html flag removed in newer version of Java Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants