Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #20

Closed
wants to merge 4 commits into from
Closed

Update #20

wants to merge 4 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 9, 2022 •
edited
Loading

This should fix some intermittent issues noticed in CI

  • Bump version
  • Remove deprecated code
  • Remove usage of guava (The dependency is no longer shipped after the version bump)

@jburel jburel closed this Nov 9, 2022
@jburel jburel reopened this Nov 9, 2022
@jburel jburel changed the title Bump version Update Nov 14, 2022
joshmoore
joshmoore approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, this whole plugin is still something of a mystery, but the changes don't look too scary and the build is green. 👍

@sbesson
Copy link
Member

sbesson commented Dec 19, 2022

Was f874083 motivated by a failure?

@sbesson
Copy link
Member

sbesson commented Dec 19, 2022

Assuming a release of this plugin is looming (see #21), what is the plan on this PR?

@jburel
Copy link
Member Author

jburel commented Dec 19, 2022

Was f874083 motivated by a failure?

no. Reducing dependencies since only one method was used

@jburel
Copy link
Member Author

jburel commented Dec 20, 2022 •
edited
Loading

I will include the Java 11 fix only
The fact that the version is not bumped daily implies that it might have some side effects so I can get back to it afterwards

@jburel jburel closed this Oct 31, 2024
@jburel jburel reopened this Oct 31, 2024
@jburel jburel mentioned this pull request Oct 31, 2024
Merged
@jburel jburel closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @sbesson @joshmoore