Add support for HCS 0.4 specification #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rowIndex/colIndex are now mandatory keys of the well element - add validation logic in the format API - add logic for generating row/column index if wells are passed as strings
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 82.11% 82.82% +0.71%
==========================================
Files 12 12
Lines 1269 1304 +35
==========================================
+ Hits 1042 1080 +38
+ Misses 227 224 -3
Continue to review full report at Codecov.
|
will-moore
reviewed
Jan 18, 2022
will-moore
reviewed
Jan 18, 2022
will-moore
reviewed
Jan 18, 2022
|
The last commits add extra validation checks ensuring the consistency of the well |
|
Looks good, thanks. |
|
@sbesson - I've started using |
jburel
reviewed
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the specification changes proposed in ome/ngff#24
rowsandcolumnsmust have unique names and be alphanumericalwellselements must includepath(composed of exactly 2 groups),rowIndexandcolIndexAs discussed in #157, the internal logic is adjusted to support the simple case of passing wells as list of strings and compute the row/column indices assuming the paths match the
rowsandcolumnslists.Unit tests are updated to cover both the new and the legacy behavior as well as various invalid cases. The reader is not adjusted to consume the new logic. I would propose to complete the work on #148 first.