Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camelCase naming style rule #70

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

will-moore
Copy link
Member

Fixes #54

Adding a note on naming convention, as agreed at #54.

This was referenced Oct 29, 2021
@sbesson
Copy link
Member

sbesson commented Nov 3, 2021

Looking around the currently open PRs, the primary one that would be affected by this style is probably #63 e.g. d_field /cc @constantinpape

No objection to defaulting to camelCase from my side either especially if we can enforce long-term consistency.

@constantinpape
Copy link
Contributor

I am fully in favor of this!

Looking around the currently open PRs, the primary one that would be affected by this style is probably #63 e.g. d_field /cc @constantinpape

At this point, #63 is only a draft to discuss ideas; when we move forward we will probably rename this to displacementField.

@joshmoore
Copy link
Member

Ok. Merging and assuming this will go live in 0.4.

@joshmoore joshmoore merged commit 3ec8d61 into ome:main Nov 8, 2021
github-actions bot added a commit that referenced this pull request Nov 8, 2021
Add camelCase naming style rule

SHA: 3ec8d61
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sbesson sbesson added this to the 0.4 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec naming style
4 participants