Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning in pytest-3.8.0 #2

Closed
tomjnixon opened this issue Sep 7, 2018 · 4 comments · Fixed by #3
Closed

Warning in pytest-3.8.0 #2

tomjnixon opened this issue Sep 7, 2018 · 4 comments · Fixed by #3

Comments

@tomjnixon
Copy link
Contributor

Hi,

I've just seen this warning when upgrading to pytest-3.8.0:

pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args

pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

I may try to fix this in the next few days (it should be easy enough), but just wanted to let you know now.

Thanks for the useful module!

Tom
@Qinusty
Copy link

Qinusty commented Sep 7, 2018

Also seeing this issue, subscribing for updates :)

@gtristan
Copy link

gtristan commented Sep 8, 2018

Also seeing this issue, would be great to have a fix for this !

tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API
06edf5a 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

Fixes omarkohl#2
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API
5592b58 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

Fixes omarkohl#2
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API
12cd010 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

This requires pytest 3.6, which does not run on python 2.6. Travis
environments have pytest 3.4 installed by default; this needs to be
explicitly updated.

Fixes omarkohl#2
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API
85d3105 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

This requires pytest 3.6, which does not run on python 2.6. Travis
environments have pytest 3.4 installed by default; this needs to be
explicitly updated.

Fixes omarkohl#2
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API if available
93b96e8 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

Fixes omarkohl#2
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API if available
e0eca6d 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

Fixes omarkohl#2
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 8, 2018
@tomjnixon
Use new pytest mark API
958a80e 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

This requires pytest 3.6, which does not run on python 2.6. Travis
environments have pytest 3.4 installed by default; this needs to be
explicitly updated.

Fixes omarkohl#2
@tomjnixon tomjnixon mentioned this issue Sep 8, 2018
Merged
tomjnixon added a commit to tomjnixon/pytest-datafiles that referenced this issue Sep 13, 2018
@tomjnixon
Use new pytest mark API
82b7411 
Process each mark separately, rather than relying on automatic merging
of args and kwargs.

See https://docs.pytest.org/en/latest/mark.html#updating-code

This requires pytest 3.6, which does not run on python 2.6. Travis
environments have pytest 3.4 installed by default; this needs to be
explicitly updated.

Fixes omarkohl#2
@omarkohl
Copy link
Owner

omarkohl commented Oct 7, 2018

This has been released with pytest-datafiles version 2.0

@tomjnixon
Copy link
Contributor Author

Excellent, thank you!

@Cynical-Optimist Cynical-Optimist mentioned this issue Oct 13, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warnings from pytest 3.8 tomjnixon/pytest-datafiles
4 participants
@tomjnixon @omarkohl @gtristan @Qinusty