Pytest 3.8.0 warnings from datafiles

[BuildStream-Migration-Bot]

See original issue on GitLab
In GitLab by [Gitlab user @Qinusty] on Sep 7, 2018, 16:05

Summary

When using Pytest 3.8.0, buildstream tests throw out a load of warnings from datafiles.

This is documented in a datafiles issue

Steps to reproduce

# Clear eggs
rm -rf .eggs

# Run some tests
./setup.py test --addopts "tests/plugins"

What is the current bug behavior?

Lots of warnings are printed.

What is the expected correct behavior?

We should have a clean test output.

Relevant logs and/or screenshots

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:71: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  content = request.keywords.get('datafiles').args
/home/joshsmith/.local/lib/python3.5/site-packages/pytest_datafiles.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  options.update(request.keywords.get('datafiles').kwargs)

Possible fixes

Wait for a datafiles patch.

---

[BuildStream-Migration-Bot]

In GitLab by [Gitlab user @tristanvb] on Sep 10, 2018, 13:31

I expect that, unfortunately we are going to have to fork datafiles as a helper in our own test utilities, as the datafiles plugin thing is very old and has not seen updates in a very long time.

On the bright side, it seems like it's probably very trivial to implement.

[BuildStream-Migration-Bot]

In GitLab by [Gitlab user @tristanvb] on Dec 16, 2018, 10:24

mentioned in commit 5005d41ca6887db9bfac1f7d03abd1a654c80f0d

[BuildStream-Migration-Bot]

In GitLab by [Gitlab user @tristanvb] on Dec 16, 2018, 10:33

mentioned in merge request !1011

[BuildStream-Migration-Bot]

In GitLab by [Gitlab user @tristanvb] on Dec 26, 2018, 19:54

mentioned in commit 80c137d

[BuildStream-Migration-Bot]

In GitLab by [Gitlab user @tristanvb] on Dec 26, 2018, 22:35

closed via merge request !1011

[BuildStream-Migration-Bot]

In GitLab by [Gitlab user @tristanvb] on Dec 26, 2018, 22:35

mentioned in commit 94b9948