Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UP] Suggestion to fix issue 79 and 71 #83

Merged
merged 4 commits into from
May 4, 2016
Merged

[UP] Suggestion to fix issue 79 and 71 #83

merged 4 commits into from
May 4, 2016

Conversation

gsilvapt
Copy link
Contributor

@gsilvapt gsilvapt commented May 2, 2016

Suggestion to fix issue 71 and 79

Right after push, got this email from GitHub about custom pages.

Never seen that so I thought it would be better to show you guys to make sure there is nothing wrong.

@gsilvapt gsilvapt changed the title [UP] Suggestion to fix issue 79 [UP] Suggestion to fix issue 79 and 71 May 2, 2016
---
layout: default
type: pattern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the blank line?

@rufuspollock
Copy link
Member

Generally looks good.

Couple of items:

  • glossary is at /glossary/glossary.md surely this should be /glossary/index.md?

  • You have this in the commit which is surely accidental:

    .Rhistory
    

    To correct you need not only to remove but to "squash" the commits because we do not want this in the commit history if possible.

@gsilvapt
Copy link
Contributor Author

gsilvapt commented May 3, 2016

I have no idea how that R temp file went over there. I haven't used R in a while!?

Anyway, I think I did everything correctly this time. Apologies for the lack of integrity there. Please let me know if I wasn't able to do it. I tried via terminal and it was just a huge mess but according to GitHub, it is worked.

Thank you for the feedback

@rufuspollock
Copy link
Member

Great!. Looks good.

@rufuspollock rufuspollock merged commit 6ca84cb into okfn:gh-pages May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants