Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "patterns" to top level directory as per our site architecture in #70 #79

Closed
danfowler opened this issue Oct 14, 2015 · 7 comments
Closed

Comments

@danfowler
Copy link
Contributor

Patterns have now been converted and now must be re-organized under /pattern/ (i.e. some are still under /pattern/patterns/ and should be moved under /pattern/).

Glossary is special and go at site root i.e. /glossary.md (actual URL path will be /glossary/) (note glossary seems to be duped in two locations atm)

@gsilvapt
Copy link
Contributor

gsilvapt commented May 2, 2016

@danfowler Should files be replaced, renamed or something else?

@rufuspollock
Copy link
Member

@gsilvapt everything should move up to live under pattern. Can i suggest you post a short summary of what you plan to do here before you do it -- this is a generally recommended workflow.

e.g.

  • I will move x to y
  • Create file y

@gsilvapt
Copy link
Contributor

gsilvapt commented May 2, 2016

In order to move the files under /patterns/patterns, some have the same name and you'll have a prompt asking if you want it to ignore those, rename or replace. My question was which one do you prefer to do in this case.

List of files with the same filename:

  • geocoding.md
  • index.md
  • liberating-html-tables.md

I can check the contents of each file to see if it is just a repetition or if the contents differ between files.

@rufuspollock
Copy link
Member

@gsilvapt have you looked at the difference between these - are they just the same file. Also see #70 for site infor architecture. Please go ahead and do a first sample pull request showing what you plan to do.

@gsilvapt
Copy link
Contributor

gsilvapt commented May 2, 2016

I was looking into all repeated files and:

  • index.md is different in both ends. Under /patterns/patterns it seems like a glossary, while the one under /patterns/ is an introductiory file. Also, patterns/index.md has as title Recipes. Should filename be changed to recipes.md or patterns.md ?
  • /patterns/geocoding.md is about how to geocode data in spreadsheets, while /patterns/patterns/geocoding.md is about a script called Geo-Googledocs allowing the user to export to GeoJSON and GEOcode arbitrary addresses.
    I'd suggest changing the /patterns/patterns/geocoding.md filename to geo-googledocs.md
  • Finally, liberating-html-tables.md is actually the same file. patterns/patterns/liberating-html-tables.md is more complete, so I will replace the file in the parent directory, if you allow me.

Hope this helps! Sorry if I am not being too independent here but I prefer asking than doing things we will struggle to fix!

@gsilvapt
Copy link
Contributor

gsilvapt commented May 2, 2016

The pull request 83 will go as follows:

  • Move /patterns/glossary.md to (new) glossary directory - there is still another glossary under pattern/appendix/
  • Merging liberating-html-tables.md in patterns/patterns/liberating-html-tables.md and /patterns/liberating-html-tables.md
  • Changing filenames as suggested in previous comment.
  • Move non-repeated files from /patterns/patterns/ to parent directory
  • Delete parent /pattern/pattern directory

Let me know what I can do to improve this and if this current structure solves this issue.
Also, please have a look at the email print I sent with the PR just to ensure everything is correct and working.

@gsilvapt
Copy link
Contributor

gsilvapt commented May 5, 2016

FIXED.

@gsilvapt gsilvapt closed this as completed May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants