Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image download/delete options are not available on mobile #2445

Closed
SebinSong opened this issue Dec 6, 2024 · 0 comments · Fixed by #2453
Closed

Image download/delete options are not available on mobile #2445

SebinSong opened this issue Dec 6, 2024 · 0 comments · Fixed by #2453
Assignees
@SebinSong
Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX

Comments

@SebinSong
Copy link
Collaborator

Problem

When an image is attached to a message in a chatroom. 'Download' and 'Delete' menus are revealed on desktop when a pointer hovers over it. But these are not available on mobile because when user taps on the image, the viewer immediately pops out.

These menus and also the file size information should be added to the image viewer.

Solution

Add buttons for these functionalities to the image viewer.
@SebinSong SebinSong added Kind:Enhancement Improvements, new features, performance upgrades, etc. App:Frontend Note:UI/UX labels Dec 6, 2024
@SebinSong SebinSong self-assigned this Dec 6, 2024
@SebinSong SebinSong mentioned this issue Dec 10, 2024
Merged
SebinSong added a commit that referenced this issue Dec 18, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2445-do…
f8c04c8 
…wnload-and-delete-image-on-mobile
SebinSong added a commit that referenced this issue Dec 18, 2024
@SebinSong
Merge remote-tracking branch 'origin/master' into sebin/task/#2445-do…
d53a71f 
…wnload-and-delete-image-on-mobile
taoeffect pushed a commit that referenced this issue Dec 18, 2024
@SebinSong
#2445 - add Download/Delete buttons and display image size in the ima…
8aad62e 
…ge viewer (#2453)

* display file-size in the image viewer

* add downloadHelper invisible link

* add cta buttons for the images in the viewer

* style the cta buttons

* conditionally show/hide delete button

* implement download / delete functionalities

* logic after the image deletion is done

* implement loader for deleting-image status

* setup event handling for DELETE_ATTACHMENT_FEEDBACK

* add some comments

* remove debugging console.log

* move image-compression logic to ChatMain.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX
Projects
None yet
Milestone
No milestone
1 participant
@SebinSong