#2445 - add Download/Delete buttons and display image size in the image viewer #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2445-download-and-delete-image-on-mobile
|
| Run status |
|
| Run duration | 08m 49s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Seems to work really well!
Fantastic work @SebinSong! One minor issue found.
| @@ -227,14 +239,18 @@ export default { | |||
| openImageViewer (objectURL) { | |||
| if (!objectURL) { return } | |||
|
|
|||
| console.log('!@# attachment list: ', this.attachmentList) | |||
|
@taoeffect Updated the PR again. |
|
@taoeffect as reported in this Slack thread, upload-image functionality is currently broken in |
|
@taoeffect Apparently, the broken image upload functionality requires us to refactor the entire image compression logic. Let me make this fix as part of this PR and let you know if it's ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2445
[screenshot]
[screenshot in forced-color mode]
The issue was that these functionalities are not available on mobile but I thought they are good additions for desktop size screen too and so made them available for both.
Thanks,