Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Add set_heating_curve service #117

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

adorobis
Copy link
Contributor

Introducing a new service to set heating curve of the boiler. Tested and working on Vitodens 200-W WB2B

@adorobis
Copy link
Contributor Author

adorobis commented Jan 4, 2023

Hi @oischinger, do you have any feedback on this feature? Could this be merged?

@oischinger
Copy link
Owner

Hi @adorobis
Sorry for the late reply. Looks good from my side.
I'll merge the PR and contribute it to HA Core. However I'm not sure if they'll accept it or if they expect slope and shift to be implemented as number entities. Let's see

@oischinger oischinger merged commit fef79bf into oischinger:master Jan 4, 2023
@adorobis
Copy link
Contributor Author

adorobis commented Jan 4, 2023

Thanks!
Indeed this could be the case but I would find it too easy to change with number entities, even by mistake. Running a service requires more deliberate action. But let's see

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants