-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ShellCheck to a few files in the tools/
directory
#402
Apply ShellCheck to a few files in the tools/
directory
#402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions! I actually wanted to process all at once, but incremental changes are also welcome! I was thinking of merging as many PRs as possible before applying the style changes because the global style changes would introduce unnecessary conflicts in the PRs, but I believe tools/
directory is safe to introduce the style changes. Thanks!
I think about a half of the suggested changes are good ones, but there are still some noises. I left comments. Could you check them?
In the function |
Thanks, but I actually prefer the previous version. The variable scope should be kept small, and I wouldn't like to change the code in a worse direction just to suppress the warnings. Two separate lines of |
Hint addressed: SC2162 Hint disabled: SC1090
Hints disabled: SC1090, SC2317
Hints addressed: SC2059, SC2155 Hints disabled: SC1003, SC2016, SC2317, SC1090, SC2155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience and all the updates! I think I'll later merge this.
I added a newline bc4018b. |
Ah, I actually think we should move the declaration of |
Thanks. I've merged it. |
This is a PR addressing ShellCheck suggestions for a few files in the
tools/
directory of this project. As there is some existing interest in improving code with ShellCheck (#365, #83), I thought it would be helpful to begin applying some of these suggestions. @akinomyoga, if you are able to review my work to check for improvements/mistakes, I would be extremely grateful!