REQUEST: Adapt spellcheck for merge requests

[Kreyren]

All bash/shell scripts should pass spellcheck (https://github.com/koalaman/shellcheck) and there are so many issues missing quotation, unexpected variable manipulation, etc..

Requsting to adapt spellcheck to prevent these issues in the future and to force quality assurance (spellcheck is free for open-source projects).

[Kreyren]

@nntoan Requesting approval.

[nntoan]

Hi @Kreyren,

Actually, the first time when I created this project I also adapt shellcheck into every pushes/pull request through Codacy.

However, there's inactive from me (no PRs merged) for such a long time and Codacy has set all projects on Codacy into the inactive state.

I've opened a new ticket on Codacy ask them to re-activate OhMyBash project. And I will update the status ASAP here.

All best,

[Kreyren]

Added shellcheck for ohmybash/oh-my-bash

@nntoan Check your access and verify access to other members.

[Kreyren]

Assigned P1 since code quality of this repository is poor and it should be prioritized.

[Kreyren]

Configuration of shellcheck is needed, investigating atm

[nntoan]

@Kreyren I've sent an invitation to our Codacy project to the email address on your GitHub profile. Please let me know if you need an invitation for other email address.

Btw for your question on Shellcheck, this is what I configured in the past on Codacy.

Thanks,
Toan

[Kreyren]

@nntoan i make some configuration already on my end, recommends your codacy to be closed and i transfer ownership of the one that i've configured

Also it's beeing discussed on Codacy some standartization for shellcheck since default configuration is not sufficient and configuring it is pita cherrypicking.

(i would have to cherrypick that again and it's like <500 things to enable)