[APM] Fixes incorrect throughput tpm values in service overview (elas…

…tic#88273) * Closes elastic#88268. Divides the throughput count of the selected range by deltaAsMinutes * update old test snapshot * update values in test snapshot * update values in test snapshot Co-authored-by: Kibana Machine <[email protected]>
ogupte · Jan 14, 2021 · 1412dfb · 1412dfb
1 parent f286eb9
commit 1412dfb
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/...s/apm/server/lib/services/get_service_instances/get_service_instance_transaction_stats.ts b/...s/apm/server/lib/services/get_service_instances/get_service_instance_transaction_stats.ts
@@ -112,6 +112,8 @@ export async function getServiceInstanceTransactionStats({
     },
   });
 
+  const deltaAsMinutes = (end - start) / 60 / 1000;
+
   return (
     response.aggregations?.[SERVICE_NODE_NAME].buckets.map(
       (serviceNodeBucket) => {
@@ -133,10 +135,10 @@ export async function getServiceInstanceTransactionStats({
             })),
           },
           throughput: {
-            value: count.value,
+            value: count.value / deltaAsMinutes,
             timeseries: timeseries.buckets.map((dateBucket) => ({
               x: dateBucket.key,
-              y: dateBucket.count.value,
+              y: dateBucket.count.value / deltaAsMinutes,
             })),
           },
           latency: {

diff --git a/...apm/server/lib/services/get_service_transaction_groups/get_transaction_groups_for_page.ts b/...apm/server/lib/services/get_service_transaction_groups/get_transaction_groups_for_page.ts
@@ -64,6 +64,8 @@ export async function getTransactionGroupsForPage({
   transactionType: string;
   latencyAggregationType: LatencyAggregationType;
 }) {
+  const deltaAsMinutes = (end - start) / 1000 / 60;
+
   const field = getTransactionDurationFieldForAggregatedTransactions(
     searchAggregatedTransactions
   );
@@ -122,7 +124,7 @@ export async function getTransactionGroupsForPage({
           latencyAggregationType,
           aggregation: bucket.latency,
         }),
-        throughput: bucket.transaction_count.value,
+        throughput: bucket.transaction_count.value / deltaAsMinutes,
         errorRate,
       };
     }) ?? [];

diff --git a/x-pack/test/apm_api_integration/basic/tests/service_overview/instances.ts b/x-pack/test/apm_api_integration/basic/tests/service_overview/instances.ts
@@ -125,7 +125,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
                 "value": 0.941324615478516,
               },
               "throughput": Object {
-                "value": 75,
+                "value": 2.5,
               },
             }
           `);
@@ -201,7 +201,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
                 "value": 70518.9328358209,
               },
               "throughput": Object {
-                "value": 134,
+                "value": 4.46666666666667,
               },
             }
           `);

diff --git a/x-pack/test/apm_api_integration/basic/tests/transactions/transactions_groups_overview.ts b/x-pack/test/apm_api_integration/basic/tests/transactions/transactions_groups_overview.ts
@@ -111,7 +111,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
             },
             "name": "DispatcherServlet#doGet",
             "throughput": Object {
-              "value": 16,
+              "value": 0.533333333333333,
             },
           }
         `);