cleanup includes #4763
Closed
cleanup includes #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder a few includes and include "position.h" where it was previously missing. Also make the order of the includes consistent, in the following way. 1. Related header (for .cpp files) 2. A blank line 3. C/C++ headers 4. A blank line 5. All other header files No functional change
Disservin
force-pushed
the
cleanup-includes
branch
from
3a99b36
to
37a4541
Compare
|
For now I've only made the order consistent and included "position.h" where it was used. There are still other headers which are implictly included but fixing all of them needs a bit more time and is perhaps better todo in another pr. |
|
This should also fix #4707 because of the |
vondele
approved these changes
Aug 26, 2023
|
Merged via 3c0e86a, thanks :-) |
|
@UniQP thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder a few includes and include "position.h" where it was previously missing. Also make the order of the includes consistent, in the following way.
No functional change