Assorted trivial cleanups, sept.2023 #4760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snicolet
added a commit
to snicolet/stockfish-pull-requests
that referenced
this pull request
Aug 22, 2023
Please comment on this pull request for the next round of trivial cleanups - include <cmath> in evaluate_nnue.cpp (fix issue official-stockfish#4707) - ... - ... closes official-stockfish#4760 no functional change
snicolet
force-pushed
the
trivial_cleanups
branch
from
21fca8e
to
cb79bed
Compare
Please comment on this pull request for the next round of trivial cleanups - include `cmath`header file in evaluate_nnue.cpp (fix issue official-stockfish#4707) - ... - ... closes official-stockfish#4760 no functional change
snicolet
force-pushed
the
trivial_cleanups
branch
from
cb79bed
to
c7e3570
Compare
Closed
|
The header is now included with the merge of #4763. So I guess we can close this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please comment on this pull request for the next round of trivial cleanups
cmathheader file in evaluate_nnue.cpp (fix issue build with gcc on mac hits abs error #4707)closes #4760
no functional change