Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: After picking up a lamp object, there is no drop action #2154

Closed
jaj22 opened this issue Sep 30, 2021 · 5 comments · Fixed by #2157
Closed

[Bug]: After picking up a lamp object, there is no drop action #2154

jaj22 opened this issue Sep 30, 2021 · 5 comments · Fixed by #2157
Assignees
Labels
Bug Something isn't working Merge pending A PR is submitted
Milestone

Comments

@jaj22
Copy link

jaj22 commented Sep 30, 2021

Describe the bug

After picking up a lamp object, there was no scroll wheel action to drop it, so you were stuck carrying it until respawning or debug console use. Seemed repeatable on the test servers, and also happened to other players.

How to reproduce

Pick up a lamp object.

May be DS-specific. I haven't checked it locally.

Version

2.5.3 test

Have you altered the code?

No

What i have changed

No response

Map

Doesn't matter

What server?

Community Test Server 2

Time bug occured (Server time/UTC)

No response

Mods

No response

Additional context

No response

@jaj22 jaj22 added the Bug Something isn't working label Sep 30, 2021
@killerswin2
Copy link

Hmm... I wonder if the add action is getting removed on respawning.

@HakonRydland
Copy link
Collaborator

It does with vanilla thanks to a3a revive system

@HakonRydland
Copy link
Collaborator

See flagAction

@killerswin2
Copy link

Nope that's not the problem. :( There's a call to readd the action in flagaction.

@jaj22
Copy link
Author

jaj22 commented Oct 1, 2021

Confirmed respawn bug. Needs adding to onPlayerRespawn, probably near initLootToCrate.

Amusingly you can workaround by walking up to your old corpse with the lamp, so we should probably be stripping actions on death too.

@jaj22 jaj22 added this to the 2.5.3 milestone Oct 1, 2021
@jaj22 jaj22 added the Merge pending A PR is submitted label Oct 1, 2021
Bob-Murphy added a commit that referenced this issue Oct 2, 2021
## What type of PR is this.
1. [X] Bug
2. [X] Change
3. [ ] Enhancement

### What have you changed and why?
- Fix bug where drop object action (for dropping lamps) wasn't added to player after respawn.
- Fix bug where actions were left on a dead player object.
- Fix bug where LTC actions could be added when disabled by params.

Also accidentally added the setOvercast functionality that solidifies the rain-removal tent option. Can't be bothered to unfuck git and separate it. Note that the overcast state changes very slowly, but it should prevent the rain from coming back.

### Please specify which Issue this PR Resolves.
closes #2154
closes #1992

### Please verify the following and ensure all checks are completed.
1. [X] Have you loaded the mission in LAN host?
2. [ ] Have you loaded the mission on a dedicated server?

### Is further testing or are further changes required?
1. [X] No
2. [ ] Yes (Please provide further detail below.)

Notes:
- Fix lamp drop action after respawn
- Added the setOvercast functionality that solidifies the rain-removal tent option
@jaj22 jaj22 self-assigned this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Merge pending A PR is submitted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants