Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of SetOvercast to remove Clouds #1992

Closed
Lazejun opened this issue Jul 3, 2021 · 4 comments · Fixed by #2157
Closed

Use of SetOvercast to remove Clouds #1992

Lazejun opened this issue Jul 3, 2021 · 4 comments · Fixed by #2157
Labels
Enhancement New feature or request Merge pending A PR is submitted Suggestion Something that needs discussing
Milestone

Comments

@Lazejun
Copy link

Lazejun commented Jul 3, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
SetRain doesen't remove Clouds, if its Rainy it's usually Cloudy aswell, removing the Rain will just remove the Rain but clouds remain, leaving the Map a bit Darker due to Clouds.

Describe the solution you'd like
A clear and concise description of what you want to happen.
SetOvercast 0 does remove the Clouds, making it Sunny again.
This might also be nice at night if clouds block the Moonlight leaving it darker than it has to be.

-----> Probably Adding Setovercast 0 to the Rain action or adding another Action just for Overcast.

@Lazejun Lazejun added Enhancement New feature or request Suggestion Something that needs discussing labels Jul 3, 2021
@Bob-Murphy
Copy link

additionals:

  • make the change take a little longer and not instantly (maybe 30 secs for rain to stop, 90-150 to get rid of overcast)
  • make sure the button can only be pressed once and then is on a cooldown with a message like "you already prayed to the weather goats, chill out" or somethig like this (idiot save)

@Bob-Murphy Bob-Murphy added this to the 2.5.2 milestone Aug 14, 2021
@Bob-Murphy Bob-Murphy modified the milestones: 2.5.2, 2.5.3, 2.5.X Aug 25, 2021
@jaj22
Copy link

jaj22 commented Sep 21, 2021

Was gonna last-minute this, but ran into some questions:

  1. Is setOvercast logically separate from setRain? Can you have rain with overcast 0?
  2. If you can force weird values (eg. the rain 1, overcast 0), what does the weather progression do afterwards?
  3. If we have a separate setOvercast function, what's a good name for it?

@Lazejun
Copy link
Author

Lazejun commented Sep 21, 2021

In Theory there can't / Won't be Rain with Overcast 0.

In practice there is Rain for a short amount of time but it will be gone if Overcast is to low.

The problem itself is that Rain and Overcast are linked, if Overcast is 1 and Rain is 0, Rain will just Rise very quickly and start to Rain.

On the Name question, no idea but I think Bob will like "Sunshine reggae"

@jaj22
Copy link

jaj22 commented Sep 27, 2021

Further investigation: setOvercast seems to ignore the time parameter unless it's very high. Otherwise it's a very slow change, maybe an hour to get from overcast 1 to overcast 0. You can use forceWeatherChange to change it instantly, but that's not good visually.

Fairly long overcast delay seems ok to me though. If people are desperate for a faster change then they can always use Zeus.

Given the linkage between overcast and rain, I'm strongly inclined to put it on one control. Might go for 0.25 overcast rather than 0 though.

@jaj22 jaj22 added the Merge pending A PR is submitted label Oct 1, 2021
Bob-Murphy added a commit that referenced this issue Oct 2, 2021
## What type of PR is this.
1. [X] Bug
2. [X] Change
3. [ ] Enhancement

### What have you changed and why?
- Fix bug where drop object action (for dropping lamps) wasn't added to player after respawn.
- Fix bug where actions were left on a dead player object.
- Fix bug where LTC actions could be added when disabled by params.

Also accidentally added the setOvercast functionality that solidifies the rain-removal tent option. Can't be bothered to unfuck git and separate it. Note that the overcast state changes very slowly, but it should prevent the rain from coming back.

### Please specify which Issue this PR Resolves.
closes #2154
closes #1992

### Please verify the following and ensure all checks are completed.
1. [X] Have you loaded the mission in LAN host?
2. [ ] Have you loaded the mission on a dedicated server?

### Is further testing or are further changes required?
1. [X] No
2. [ ] Yes (Please provide further detail below.)

Notes:
- Fix lamp drop action after respawn
- Added the setOvercast functionality that solidifies the rain-removal tent option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Merge pending A PR is submitted Suggestion Something that needs discussing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants