Adapt to newer versions selenium webdriver #314
Conversation
AlfonsoUceda
force-pushed
the
adapt-puffing-billing-to-newer-versions-selenium-webdriver
branch
from
63466c0 to
2a3b70c
Compare
|
@oesmith I don't see that the CI runs, are you still using travis? Would you like to use github actions instead? |
|
@ronwsmith I forgot to ping you. |
|
Hi @ronwsmith, could you take a look? |
|
@AlfonsoUceda good catch on missing CI. I totally missed the changes with Travis. I just switched it over to Github Actions. Mind updating your PR and ensuring those pass? |
|
@ronwsmith I've updated the PR but I think it needs some approval from your side to run the CI |
|
@ronwsmith seems that watir and selenium-webdriver gems need a higher version of ruby. Are you open to restrict the minimum ruby version to 2.7? I can do it in this PR and also adapt the github actions. In addition, it could be a major release version. |
|
@AlfonsoUceda Yes, I have to approve first time contributors. Looks like your gemspec changes are not backwards compatible to currently supported ruby versions. Please take a look. |
|
@AlfonsoUceda we were reviewing at the same time :). How about we do a separate PR to get everything working with Ruby 2.7, 2.8, 2.9, 3.0, 3.1 without gem changes (if possible). Then once we get updated there, we can do this forced selenium update and compatibility change and make a major version change (removing the older versions). |
|
Perfect @ronwsmith, will do it tomorrow |
AlfonsoUceda
force-pushed
the
adapt-puffing-billing-to-newer-versions-selenium-webdriver
branch
from
e6b9ea7 to
6b60ad6
Compare
|
@ronwsmith I've rebased latest master in the branch and also removed all deprecation warnings. |
The gem does not need to include all files that are needed for development. In addition, bump minimum required version of selenium-webdriver to 3.150.0
…e, it does not exist anymore. In addition, remove deprecation warning when creating the selenium driver passing the capabilities param, instead of options and desired_capabilities params.
AlfonsoUceda
force-pushed
the
adapt-puffing-billing-to-newer-versions-selenium-webdriver
branch
from
6b60ad6 to
3f34a44
Compare
ronwsmith
changed the title
|
Released in 3.0.1. Thanks for the contributions! |
AlfonsoUceda
deleted the
adapt-puffing-billing-to-newer-versions-selenium-webdriver
branch
This PR introduces two changes, the first one is in the gemspec file where the gem generated included all files, but now it will require only the needed ones.
@oesmith could you confirm that this is correct? Do you need the binary to be included? You don't mention it in the README so I guess it is not for the gem.
Another change in the gemspec is to bump the minimum required version to 3.150.0 where
assume_untrusted_certificate_issuerwas removed from the firefox profile class.The last change is in
lib/billy/browsers/capybara.rb, where I removedassume_untrusted_certificate_issuer(I don't know what the alternative is) and also remove deprecation warnings to usecapabilitiesparam instead ofoptionsanddesired_capabilities.