Remove assume_untrusted_certificate_issuer option from firefox profil…

…e, it does not exist anymore. In addition, remove deprecation warning when creating the selenium driver passing the capabilities param, instead of options and desired_capabilities params.
oesmith · Feb 15, 2022 · 3f34a44 · 3f34a44
1 parent 866a039
commit 3f34a44
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/lib/billy/browsers/capybara.rb b/lib/billy/browsers/capybara.rb
@@ -47,19 +47,24 @@ def self.register_webkit_driver
 
       def self.register_selenium_driver
         ::Capybara.register_driver :selenium_billy do |app|
-          options = build_selenium_options_for_firefox
-          capabilities = Selenium::WebDriver::Remote::Capabilities.firefox(accept_insecure_certs: true)
+          capabilities = [
+            build_selenium_options_for_firefox,
+            Selenium::WebDriver::Remote::Capabilities.firefox(accept_insecure_certs: true)
+          ]
 
-          ::Capybara::Selenium::Driver.new(app, options: options, desired_capabilities: capabilities)
+          ::Capybara::Selenium::Driver.new(app, capabilities: capabilities)
         end
 
         ::Capybara.register_driver :selenium_headless_billy do |app|
           options = build_selenium_options_for_firefox.tap do |opts|
             opts.add_argument '-headless'
           end
-          capabilities = Selenium::WebDriver::Remote::Capabilities.firefox(accept_insecure_certs: true)
-
-          ::Capybara::Selenium::Driver.new(app, options: options, desired_capabilities: capabilities)
+          capabilities = [
+            options,
+            Selenium::WebDriver::Remote::Capabilities.firefox(accept_insecure_certs: true)
+          ]
+
+          ::Capybara::Selenium::Driver.new(app, capabilities: capabilities)
         end
 
         ::Capybara.register_driver :selenium_chrome_billy do |app|
@@ -70,7 +75,7 @@ def self.register_selenium_driver
           ::Capybara::Selenium::Driver.new(
             app,
             browser: :chrome,
-            options: options,
+            capabilities: options,
             clear_local_storage: true,
             clear_session_storage: true
           )
@@ -88,7 +93,7 @@ def self.register_selenium_driver
           ::Capybara::Selenium::Driver.new(
             app,
             browser: :chrome,
-            options: options,
+            capabilities: options,
             clear_local_storage: true,
             clear_session_storage: true
           )
@@ -105,7 +110,6 @@ def self.register_apparition_driver
 
       def self.build_selenium_options_for_firefox
         profile = Selenium::WebDriver::Firefox::Profile.new.tap do |prof|
-          prof.assume_untrusted_certificate_issuer = false
           prof.proxy = Selenium::WebDriver::Proxy.new(
             http: "#{Billy.proxy.host}:#{Billy.proxy.port}",
             ssl: "#{Billy.proxy.host}:#{Billy.proxy.port}")