Keep compatible with em-http-request > 1.1.3 #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to reproduce original behaviour, not sure correect as there is no documenting spec for the header delete... But looks like trying to avoid e.g. gzip request, however em-http-request default behaviour changed in 1.1.4 to default to use gzip if header is missing.
|
Thanks @damned for the contribution. Will let original reporter have a chance to try it out before I merge. |
|
@damned can you resolve the conflicts if you'd like to maintain your encoder heading change? |
|
@damned @ronwsmith I just hit my head on this. I can confirm that the change in this PR fixes the problem in #204 which appears to be unrelated to https usage. |
|
Stale PR, closing. Feel free to reopen and continue if this is still an issue. |
Merged
|
Fixed in v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When puffing billy makes a proxy request, it appears to try to force accepting only raw (identity?) encoding and avoid e.g. gzip'd response.
It has been doing this by deleting the accept-encoding header.
em-http-request 1.1.4 has changed its default behaviour to default accept-encoding header if not already set. igrigorik/em-http-request@8c72228
this PR attempts to fix by forcing accept-encoding to empty value instead which effectively explicitly tells em-http-request to not request an encoding