EventMachine 1.1.4 breaks certain puffing-billy requests

[asafbrukarz]

A change made to the default request compressing in em-http-request (igrigorik/em-http-request@8c72228) has broken certain puffing billy requests for us.

This took a long time to diagnose, but when requests are made to load Google maps from the client, //maps.googleapis.com/maps/api/js?v=3.exp&callback=... the proxy returns a 0 length response.

Locking em-http-request to 1.1.3 fixes this issue. Any thoughts?

[ronwsmith]

Let's pin the version for now until someone has time to investigate further. Can you PR that?

[damned]

just issued a pull request to a potential fix for this: #167

build now seems to work against em-http-request 1.1.4, 1.1.5 - previously these versions were failing the puffing billy build for me.

[ronwsmith]

@asafbrukarz does the PR from @damned fix the issue you were seeing?

[ronwsmith]

@asafbrukarz any update here?

[AlanFoster]

We're hitting unexpected errors, potentially related to this issue. Any updates would be good 👍

[ronwsmith]

@AlanFoster can you try the fix in this PR: #167 If it works, I'll get it merged in soon.

[rogerkk]

I'm sorry if this is not the best place to post this question, but I'm struggling with getting puffing-billy installed and stumbled upon this issue. Perhaps any answer to my question can help someone else with the same issue:

The puffing-billy master branch (and the 0.9.2 gem) seems to be pinned to eventmachine ~> 1.0.4, but I have other gems depending on a more recent version of eventmachine.

This issue mentions eventmachine 1.1.4, but could someone help me understand how I even get to install puffing-billy with that (or more recent) versions of eventmachine?

[ronwsmith]

@rogerkk try using the branch from PR #167 and see if that works for you.

[hisenb3rg]

@ronwsmith Any idea when #167 can be merged? I have similar issue with billy as @rogerkk, have other gems depending on newer version of eventmachine...

[ronwsmith]

@jurglic have you tried using that branch to verify it works before I merge it?

[hisenb3rg]

@ronwsmith Yes I'm using this branch. Additionally I've bumped addressable to 2.5.0 and eventmachine to 1.2.3 (bb87529).

All works for me.

[ronwsmith]

@jurglic Great, thanks for verifying! Can you create a PR with those two updated gems and this change?

[hisenb3rg]

Sure, will do

[ronwsmith]

I lot has changed around gems since this PR was opened.

Are people still having the same issues using 0.12.0?

[dmitry]

Probably a good idea would be to close this issue, as it seems eventmachine was updated to a lot newer version, so it might be solved.

[ronwsmith]

Feel free to reopen if anything comes up

[dreyks]

Um... so, what's the current state with EM compatibility? My code already uses EM at 1.2.3 so I can't install puffing-billy which is still at ~> 1.0.4
bb87529 seems not to exist in any branch anymore

[dreyks]

More info

It seems like first the em version was pinned to ~> 1.0.4 by #206 because something was breaking with em > 1.0.9.1
But in several months the requirement was pinned to 1.2.0.1 in #217 by same person @mwjeffcott
The question is Why would we pin it then if it's already past 1.0.9.1?

Also #212 pins em version back to ~> 1.0.4 presumably because of watir (which is a development dependency...) more info

[ronwsmith]

@dreyks feel free to open up a new PR with a fix.