Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old school version #64

Merged
merged 86 commits into from
Sep 4, 2023
Merged

Old school version #64

merged 86 commits into from
Sep 4, 2023

Conversation

volodymyrss
Copy link
Member

No description provided.

The [MMODA](https://www.astro.unige.ch/mmoda) platform provides access to the Astronomical Open Research Data Analysis Services (ORDAS). Good fraction of these services follow a simple scheme: they
* access publicly available external astronomical data archives to fetch data relevant to specific source or source catalog,
* transform the fetched data using a workflow based on a Python notebook, to drive a data product and
The users of [MMODA](https://www.astro.unige.ch/mmoda) are encouraged to become its developers and add new ORDAS. This help page provides a step-by step instructions on how to add new services to MMODA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating line 9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put a suggestion?

Copy link
Contributor

@burnout87 burnout87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some, mostly minor, comments here and there. But overall I think is clear

content/docs/guide-development.md Show resolved Hide resolved
content/docs/guide-development.md Outdated Show resolved Hide resolved
content/docs/guide-development.md Outdated Show resolved Hide resolved
content/docs/guide-development.md Show resolved Hide resolved
content/docs/guide-development.md Outdated Show resolved Hide resolved
content/docs/guide-development.md Show resolved Hide resolved

### Annotate the notebook outputs
![image](https://github.com/oda-hub/hugo-odahub/blob/master/content/docs/tmp2.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![image](https://github.com/oda-hub/hugo-odahub/blob/master/content/docs/tmp2.png)
![](tmp2.png)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it would be good to change all of the references to local

content/docs/guide-development.md Outdated Show resolved Hide resolved
content/docs/guide-development.md Show resolved Hide resolved
content/docs/guide-development.md Outdated Show resolved Hide resolved
Copy link
Contributor

@burnout87 burnout87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added url to create new project with MModa template

@burnout87 burnout87 mentioned this pull request Aug 30, 2023
@volodymyrss volodymyrss merged commit 0694ba5 into master Sep 4, 2023
@volodymyrss
Copy link
Member Author

I think we collected enough comments from anyone who was interested. Further are always comments welcome after it's published!

@andriineronov
Copy link
Contributor

I've now added couple of more things:

– explain how to handle exceptions,
– explain how to view progress on GitLab CI/CD

I think what is still missing is

– how to add acknowledgements

(I do not know how to do it myself.....)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants