Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): eventPayload parameter for Webhooks#verify can be string #388

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

G-Rath
Copy link
Member

@G-Rath G-Rath commented Dec 11, 2020

🤦 I forgot to adjust this type too when doing #387

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not your fault, we should have tests in place to catch things like this. If only testing TypeScript wouldn't be so hard :( Thanks for the follow up fix!

@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Dec 11, 2020
@gr2m gr2m merged commit bc4a071 into octokit:master Dec 11, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.18.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@G-Rath G-Rath deleted the adjust-param-type-again branch December 13, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants