Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): eventPayload parameter for verify() can be string #387

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

G-Rath
Copy link
Member

@G-Rath G-Rath commented Dec 11, 2020

As per this comment, eventPayload can be either a string or an object, but currently it only accepts an object type.

@gr2m gr2m changed the title fix: mark eventPayload param for verify as string | object fix(typescript): eventPayload parameter for verify() can be string Dec 11, 2020
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m modified the milestone: fix Dec 11, 2020
@gr2m gr2m added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Dec 11, 2020
@gr2m gr2m merged commit 1c405ab into octokit:master Dec 11, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.18.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants