Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish support for downloading the code archive #810

Merged
merged 5 commits into from
Jun 1, 2015

Conversation

shiftkey
Copy link
Member

This was started in #765 but due to #808 we either need to:

  • implement a workaround for users to opt-out of redirects, leave the feature incomplete
  • just finish the feature, make retrieving the link unnecessary

I've favoured the latter, and marked the existing GetArchiveLink methods as obsolete.

Doing this as a separate PR into the redirect PR so we can discuss whether users want to access the link without initiating the download.

Fixes #748

cc @alfhenrik

@hnrkndrssn
Copy link
Contributor

Yep, sounds good to me.
Reading the API docs, the purpose of that endpoint is to redirect to the actual content so we should probably adhere to that I guess 😄

And if someone is crying out for functionality to get just the link then we can reconsider and add that back in.

@shiftkey
Copy link
Member Author

shiftkey commented Jun 1, 2015

Thanks @alfhenrik for the sanity check!

shiftkey added a commit that referenced this pull request Jun 1, 2015
finish support for downloading the code archive
@shiftkey shiftkey merged commit ea48040 into redirect-requests Jun 1, 2015
@shiftkey shiftkey deleted the fix-redirect-with-archive-link branch June 1, 2015 03:16
@hnrkndrssn
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants