Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Archive Link for Repository Contents #748

Closed
shiftkey opened this issue Mar 10, 2015 · 5 comments · Fixed by #808
Closed

Get Archive Link for Repository Contents #748

shiftkey opened this issue Mar 10, 2015 · 5 comments · Fixed by #808
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

Reference: https://developer.github.com/v3/repos/contents/#get-archive-link

This should belong under IRepositoryContentsClient but the workflow for turning a 302 into actual content might need a bit of thought.

@hnrkndrssn
Copy link
Contributor

I'll take a 👟 🏈 at this one

@hnrkndrssn
Copy link
Contributor

Looking at Octokit.rb the Get Archive Link method just returns the URL returned in the Location header, so I started thinking and thought I'd ask, for Octokit.net should we provide two methods:

  • one that just returns the URL in the Location header, and
  • one that (somehow) follows the redirect and returns the contents of the archive?

@shiftkey
Copy link
Member Author

Definitely have the first option. If the second option is easy enough to add in, I'd happily accept it as well...

@hnrkndrssn
Copy link
Contributor

First option is the easy one 😀 It's the second one that will take some 💭

@shiftkey
Copy link
Member Author

Note: #808 will complete this feature (by introducing GetArchive which follows the received 302) and the old GetArchiveLink will be obsoleted in a future release.

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants