Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: GetAllStargazersWithTimestamps was not returning timestamps #2785

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

thomhurst
Copy link
Contributor

Resolves #2784


Before the change?

Method returned null data and threw when trying to access user data
*

After the change?

User data is populated
*

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Sep 26, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomhurst Thanks for knocking this out ❤️ !

@nickfloyd nickfloyd changed the title Fix GetAllStargazersWithTimestamps [bug]: GetAllStargazersWithTimestamps was not returning timestamps Sep 26, 2023
@nickfloyd nickfloyd merged commit 0238092 into octokit:main Sep 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Dates are not returned
2 participants