Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Dates are not returned #2784

Closed
1 task done
aloneguid opened this issue Sep 25, 2023 · 1 comment · Fixed by #2785
Closed
1 task done

[BUG]: Dates are not returned #2784

aloneguid opened this issue Sep 25, 2023 · 1 comment · Fixed by #2785
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@aloneguid
Copy link

What happened?

var stars2 = await client.Activity.Starring.GetAllStargazersWithTimestamps("user", "repo");

returns null users and default dates:

image

Versions

8.0.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aloneguid aloneguid added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Sep 25, 2023
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone hacktoberfest Issues for participation in Hacktoberfest and removed Status: Triage This is being looked at and prioritized labels Sep 25, 2023
@nickfloyd
Copy link
Contributor

Hey @aloneguid, it looks like the header value is not being applied in these requests. According to the docs:

There is one supported custom media type for these endpoints. When you use this custom media type, you will receive a response with the starred_at timestamp property that indicates the time the star was created. The response also has a second property that includes the resource that is returned when the custom media type is not included. The property that contains the resource will be either user or repo.

application/vnd.github.star+json

ex.
curl https://api.github.com/repos/Octokit/octokit.net/stargazers -H 'accept:application/vnd.github.star+json'

It really should be provided here in the base implementation of GetAllStargazersWithTimestamps

I'll put this in our backlog and label it with up for grabs - feel free to tackle it if you get a moment and thank you for helping this SDK and community get better at what it does! ❤

@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Sep 25, 2023
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants