update models with updated permission enum

.editorconfig

@@ -0,0 +1,3 @@
+root=true
+[*.cs]
+end_of_line = lf

Octokit.Tests.Integration/Clients/TeamsClientTests.cs

@@ -33,6 +33,7 @@ public async Task CreatesTeam()
                 Assert.Equal(teamName, team.Name);
                 Assert.Equal(teamDescription, team.Description);
                 Assert.Equal(TeamPrivacy.Closed, team.Privacy);
+                Assert.Equal(TeamPermission.Pull, team.Permission);
                 Assert.Equal(1, team.MembersCount);
                 Assert.Equal(1, team.ReposCount);
 
@@ -445,10 +446,14 @@ public async Task UpdatesTeam()
             {
                 var teamName = Helper.MakeNameWithTimestamp("updated-team");
                 var teamDescription = Helper.MakeNameWithTimestamp("updated description");
+
+                // setting TeamPermission.Admin fails with Octokit.ApiValidationException : Setting team permission to admin is no longer supported
+                var teamPermission = TeamPermission.Push;
                 var update = new UpdateTeam(teamName)
                 {
                     Description = teamDescription,
                     Privacy = TeamPrivacy.Closed,
+                    Permission = teamPermission,
                     ParentTeamId = parentTeamContext.TeamId
                 };
 
@@ -457,6 +462,7 @@ public async Task UpdatesTeam()
                 Assert.Equal(teamName, team.Name);
                 Assert.Equal(teamDescription, team.Description);
                 Assert.Equal(TeamPrivacy.Closed, team.Privacy);
+                Assert.Equal(teamPermission, team.Permission);
                 Assert.Equal(parentTeamContext.TeamId, team.Parent.Id);
             }
         }

Octokit.Tests/SimpleJsonSerializerTests.cs

@@ -472,12 +472,12 @@ public void ShouldDeserializeParentTeamWithNullPermission()
                 var result = new SimpleJsonSerializer().Deserialize<Team>(teamJson);
 
                 // original value works as expected
-                Assert.Equal(PermissionLevel.Admin, result.Permission.Value);
+                Assert.Equal(TeamPermission.Admin, result.Permission.Value);
                 Assert.Equal("admin", result.Permission.StringValue);
 
                 // parent permission is marked as null and cannot be parsed
                 Assert.Equal("null", result.Parent.Permission.StringValue);
-                PermissionLevel value;
+                TeamPermission value;
                 Assert.False(result.Parent.Permission.TryParse(out value));
             }
         }

Octokit/Models/Request/NewTeam.cs

@@ -55,7 +55,7 @@ public NewTeam(string name)
         /// <summary>
         /// The permission that new repositories will be added to the team with when none is specified (default: Pull)
         /// </summary>
-        public Permission? Permission { get; set; }
+        public NewTeamPermission? Permission { get; set; }
 
         /// <summary>
         /// Id of a team to set as the parent team

Octokit/Models/Request/Permission.cs

@@ -39,4 +39,52 @@ public enum Permission
         [Parameter(Value = "pull")]
         Pull
     }
+
+    /// <summary>
+    /// Deprecated. The permission that new repositories will be added to the team with when none is specified
+    /// Default: pull
+    /// Can be one of: pull, push
+    /// </summary>
+    [SuppressMessage("Microsoft.Naming", "CA1711:IdentifiersShouldNotHaveIncorrectSuffix")]
+    public enum NewTeamPermission
+    {
+        /// <summary>
+        /// team members can pull, but not push to or administer these repositories
+        /// </summary>
+        [Parameter(Value = "pull")]
+        Pull,
+
+        /// <summary>
+        /// team members can pull and push, but not administer these repositories
+        /// </summary>
+        [Parameter(Value = "push")]
+        Push
+    }
+
+    /// <summary>
+    /// Deprecated. The permission that new repositories will be added to the team with when none is specified.
+    /// Default: pull
+    /// Can be one of: pull, push, admin
+    /// </summary>
+    [SuppressMessage("Microsoft.Naming", "CA1711:IdentifiersShouldNotHaveIncorrectSuffix")]
+    public enum TeamPermission
+    {
+        /// <summary>
+        /// team members can pull, but not push to or administer these repositories
+        /// </summary>
+        [Parameter(Value = "pull")]
+        Pull,
+
+        /// <summary>
+        /// team members can pull and push, but not administer these repositories
+        /// </summary>
+        [Parameter(Value = "push")]
+        Push,
+
+        /// <summary>
+        ///  team members can pull, push and administer these repositories.
+        /// </summary>
+        [Parameter(Value = "admin")]
+        Admin,
+    }
 }

Octokit/Models/Request/UpdateTeam.cs

@@ -37,7 +37,7 @@ public UpdateTeam(string name)
         /// <summary>
         /// The permission that new repositories will be added to the team with when none is specified (default: Pull)
         /// </summary>
-        public Permission? Permission { get; set; }
+        public TeamPermission? Permission { get; set; }
 
         /// <summary>
         /// Id of a team to set as the parent team

Octokit/Models/Response/Team.cs

@@ -12,7 +12,7 @@ public class Team
     {
         public Team() { }
 
-        public Team(string url, string htmlUrl, int id, string nodeId, string slug, string name, string description, TeamPrivacy privacy, PermissionLevel permission, int membersCount, int reposCount, Organization organization, Team parent, string ldapDistinguishedName)
+        public Team(string url, string htmlUrl, int id, string nodeId, string slug, string name, string description, TeamPrivacy privacy, TeamPermission permission, int membersCount, int reposCount, Organization organization, Team parent, string ldapDistinguishedName)
         {
             Url = url;
             HtmlUrl = htmlUrl;
@@ -73,7 +73,7 @@ public Team(string url, string htmlUrl, int id, string nodeId, string slug, stri
         /// <summary>
         /// permission attached to this team
         /// </summary>
-        public StringEnum<PermissionLevel> Permission { get; private set; }
+        public StringEnum<TeamPermission> Permission { get; private set; }
 
         /// <summary>
         /// how many members in this team