-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update models with updated permission enum #2633
Changes from all commits
409c586
ce9df33
0eed292
9b6164a
1ad585e
9c45e17
3a3dbdd
754bece
82593bd
b354217
a976530
c22a76d
c5f0cf4
3b16170
76cfbff
d05c0cd
baee285
1c6313d
a6be98d
d6f345b
c01bb60
d0f4f0c
cba9141
426abdf
19dd149
38b0881
de786e0
a76d81a
e38ec35
d194b68
28a36d6
662b40a
2a6497f
d40e981
f98829f
a4deb95
f3d6980
960382c
62de913
7f1bd0e
b13a43c
4e2c833
aa6788f
ca7de3b
c73545b
2ec885d
31a2e9c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,8 @@ public void NoStalePreviews() | |
// https://developer.github.com/v3/repos/commits/#get-a-single-commit | ||
"application/vnd.github.v3.sha", | ||
// https://developer.github.com/v3/activity/starring/#alternative-response-with-star-creation-timestamps | ||
"application/vnd.github.v3.star+json" | ||
"application/vnd.github.v3.star+json", | ||
"application/vnd.github.v3.repository+json" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you mind explaining to me the reason for this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added RepositoryContentMediaType to AcceptHeaders for passing repository media type in CheckTeamPermissionsForARepositoryWithCustomAcceptHeader. This caused this convention test to fail because now it expects "application/vnd.github.v3.repository+json" in defaultHeaders |
||
}; | ||
|
||
var validHeaders = defaultHeaders.Concat(previewAcceptHeaders); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on providing a link or some other manner to direct users towards the new endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great suggestion. I will provide a link to the new endpoint in the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, looking forward to it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a link