handle case insensitive headers when parsing for API rate limiting #2175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2161 but probably not the full fix, given we pass around a dictionary and lookup by key, rather than following the HTTP spec and supporting case insensitive headers.
I chatted with some others inside GitHub and they reminded me about RFC 2616, section 4.2:
I'd love to get to a place where we can leverage
HttpResponseHeaders
but we are very tightly coupled toIResponse
in the internals, and it's this component that manages the headers as a dictionary:octokit.net/Octokit/Http/IResponse.cs
Lines 32 to 35 in a25863f
The setup is here, which converts the
HttpResponseHeaders
into a dictionary:octokit.net/Octokit/Http/HttpClientAdapter.cs
Lines 125 to 129 in a25863f
You'll also note that headers can have multiple values, so the eventual refactoring would need to support that.
TryGetValue
without handling case-insensitive headers