This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix detecting GitHub Enterprise Server behind a HAProxy #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcansdale
changed the title
This was referenced Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
X-GitHub-Request-Idheader is used to check whether an error is returned from a GitHub or GitHub Enterprise server instance. If the server is behind a HAProxy, the header will be converted to lower case. We were only checking for a case sensitiveX-GitHub-Request-Idheader and not detecting GHES instances behind a HAProxy proxy.What this PR does
X-GitHub-Request-IdheaderCredits
This bug was discovered and documented by @osmanager in #2560. Thankyou!
Related
handle case insensitive headers when parsing for API rate limiting octokit/octokit.net#2175
Fixes #2560