Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Draft Pull Requests #2009

Merged
merged 5 commits into from
Sep 22, 2019
Merged

Implement Draft Pull Requests #2009

merged 5 commits into from
Sep 22, 2019

Conversation

hnrkndrssn
Copy link
Contributor

@hnrkndrssn hnrkndrssn commented Sep 21, 2019 •
edited
Loading

  • Tests, tests, tests

Fixes #1945

@codecov
Copy link

codecov bot commented Sep 21, 2019 •
edited
Loading

Codecov Report

Merging #2009 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
- Coverage   70.88%   70.85%   -0.03%     
==========================================
  Files         529      529              
  Lines       13958    13961       +3     
==========================================
- Hits         9894     9892       -2     
- Misses       4064     4069       +5
Impacted Files Coverage Δ
Octokit/Helpers/AcceptHeaders.cs 100% <ø> (ø) ⬆️
Octokit/Models/Response/PullRequest.cs 12.5% <0%> (-0.33%) ⬇️
Octokit/Models/Request/NewPullRequest.cs 73.33% <0%> (-5.24%) ⬇️
...t.Reactive/Clients/ObservablePullRequestsClient.cs 100% <100%> (ø) ⬆️
Octokit/Clients/PullRequestsClient.cs 80.85% <100%> (ø) ⬆️
Octokit/SimpleJson.cs 71.76% <0%> (-0.27%) ⬇️

@hnrkndrssn hnrkndrssn force-pushed the enh-draftpullrequests branch from 651562d to d4b71e8 Compare September 21, 2019 21:26
@hnrkndrssn hnrkndrssn marked this pull request as ready for review September 21, 2019 22:52
@shiftkey shiftkey self-assigned this Sep 22, 2019
shiftkey
shiftkey approved these changes Sep 22, 2019
View reviewed changes
Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent - thanks for pulling all of this in @hnrkndrssn!

@shiftkey shiftkey merged commit fafbf33 into octokit:master Sep 22, 2019
@shiftkey
Copy link
Member

release_notes: add support for retrieving and creating draft pull requests

@hnrkndrssn hnrkndrssn deleted the enh-draftpullrequests branch September 22, 2019 22:32
@shiftkey shiftkey mentioned this pull request Oct 1, 2019
Closed
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees

@shiftkey shiftkey

Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the new Draft Pull Requests
3 participants
@hnrkndrssn @shiftkey @nickfloyd