Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new Draft Pull Requests #1945

Closed
guilhermemoschen opened this issue Feb 20, 2019 · 7 comments · Fixed by #2009
Closed

Implement the new Draft Pull Requests #1945

guilhermemoschen opened this issue Feb 20, 2019 · 7 comments · Fixed by #2009
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@guilhermemoschen
Copy link

Hello, at 2019-02-14, GitHub released a preview about the new draft pull request.
https://developer.github.com/changes/2019-02-14-draft-pull-requests/

I'd like to request an update include this new boolean flag at PullRequest.

Thanks!

@ryangribble
Copy link
Contributor

Hi @guilhermemoschen

it would be great to support this new feature, would you be keen to work on a PR to add it?

@guilhermemoschen
Copy link
Author

Yes, I think I can try to do it ;)

@ShenLanJohn
Copy link

any update for this issue? Thanks!

@guilhermemoschen
Copy link
Author

guilhermemoschen commented Jun 13, 2019

Is it possible to use ApiConnection.Get<T> to return the draft information if you define a new model. Something like PullRequestWithDraft : PullRequest.

So you can:

var pullRequestWithDraft = apiConneciton.Get<PullRequestWithDraft>(...);

@ShenLanJohn
Copy link

Thanks Guilherme! will try!

@l1salvatore
Copy link

Hi all,
any updates on this? Last version 0.32 in Nugget doesn't support Draft boolean and i want to use this.

Thanks

@l1salvatore
Copy link

l1salvatore commented Aug 2, 2019

On the other hand,, is there a way to build a filter instance of a class against Github API with this property?
At the moment i'm filtering issues and then i look up the pull request with the same id and check the Mergeable State

@nickfloyd nickfloyd added Type: Feature New feature or request Status: Up for grabs Issues that are ready to be worked on by anyone and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants