Add ability to specify 'since' request parameter to issue comments #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since' a specific date
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
==========================================
+ Coverage 70.82% 70.87% +0.05%
==========================================
Files 529 529
Lines 13928 13956 +28
==========================================
+ Hits 9864 9892 +28
Misses 4064 4064
|
hnrkndrssn
changed the title
hnrkndrssn
changed the title
shiftkey
approved these changes
Sep 21, 2019
|
release_notes: added |
nickfloyd
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, ApiOptions otpions)didn't specifyAcceptHeaders.ReactionsPreviewso I added this as part of my changes.? (I checked theGetAllForRepositorymethod and noticed that there are no tests that use theIssueCommentRequestparameter, but I can add tests for theGetAllForIssueif desired)Codecovclearly wants me to write some tests 😁Fixes #1960