Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Issue Comments Since Request Parameter #1960

Closed
andyesys opened this issue Apr 12, 2019 · 2 comments · Fixed by #2008
Closed

Missing Issue Comments Since Request Parameter #1960

andyesys opened this issue Apr 12, 2019 · 2 comments · Fixed by #2008
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@andyesys
Copy link

andyesys commented Apr 12, 2019 •
edited
Loading

Issue.Comment.GetAllForIssue() has no way to provide the since request parameter described here: https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue.
@ryangribble
Copy link
Contributor

Thanks for flagging this @andyesys! Would be great if you wanted to send a PR to add it!

@hnrkndrssn hnrkndrssn mentioned this issue Sep 21, 2019
Merged
1 task
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to specify 'since' request parameter to issue comments hnrkndrssn/octokit.net
4 participants
@nickfloyd @ryangribble @andyesys and others